test(Button): auto generate visual test #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
itwillwork
commented
May 31, 2024
itwillwork
commented
May 31, 2024
| @@ -0,0 +1,75 @@ | |||
| import chunk from 'lodash/chunk'; | |||
There was a problem hiding this comment.
a utility for generating regressive tests
There was a problem hiding this comment.
We don't plan to use it, let's remove
itwillwork
commented
May 31, 2024
| import {ButtonStories, CustomIconSizeButton} from './helpersPlaywright'; | ||
|
|
||
| test.describe('Button', () => { | ||
| test.describe('Button', {tag: '@Button'}, () => { |
There was a problem hiding this comment.
added a tag for the component so that you can run tests for one or more components
itwillwork
commented
May 31, 2024
package.json
Outdated
| @@ -85,7 +85,7 @@ | |||
| "typecheck": "tsc --noEmit", | |||
| "prepublishOnly": "npm run build", | |||
| "playwright:install": "playwright install --with-deps", | |||
| "playwright": "playwright test --config=playwright/playwright.config.ts", | |||
| "playwright": "playwright test --config=playwright/playwright.config.ts --grep-invert=@regression", | |||
There was a problem hiding this comment.
all components without regression tests
playwright test --config=playwright/playwright.config.ts --grep-invert=@regression
one component
playwright test --config=playwright/playwright.config.ts --grep=@Button
one component with smoke tests
playwright test --config=playwright/playwright.config.ts --grep=@Button --grep=@smoke
all smoke tests
playwright test --config=playwright/playwright.config.ts --grep=@smoke
itwillwork
force-pushed
the
auto-generate-visual-test
branch
from
f44827d to
1f69dda
Compare
|
Visual Tests Report is ready. |
itwillwork
changed the title
|
removed regression tests |
itwillwork
changed the title
itwillwork
changed the title
itwillwork
changed the title
itwillwork
changed the title
amje
approved these changes
Jul 6, 2024
amje
requested changes
Jul 11, 2024
|
|
||
| export const loadingCases: Cases<ButtonProps['loading']> = [['loading', true]]; | ||
|
|
||
| export const viewsCases: Cases<ButtonProps['view']> = [ |
There was a problem hiding this comment.
Decided to keep flat array of values in cases
| @@ -0,0 +1,75 @@ | |||
| import chunk from 'lodash/chunk'; | |||
There was a problem hiding this comment.
We don't plan to use it, let's remove
amje
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.